Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PartyTaxScheme xsd validation error with passing null as scheme #26

Closed
andras-minicrm opened this issue Jun 14, 2022 · 0 comments · Fixed by #27
Closed

PartyTaxScheme xsd validation error with passing null as scheme #26

andras-minicrm opened this issue Jun 14, 2022 · 0 comments · Fixed by #27

Comments

@andras-minicrm
Copy link

Hi @josemmo!

It seems I've encountered a bug

$Seller->setTaxRegistrationId(
    new Identifier("12345678")
);

This generates an invalid xml (validated by xsd validation), because <cac:TaxScheme> node is missing in the generated xml. It appears that <cac:TaxScheme/> is the valid option here.

You can validate against xsd here:
https://ecosio.com/en/peppol-and-xml-document-validator/
Example xml-s (check line 48 <cac:PartyTaxScheme> node):
taxscheme_with_value.txt Valid
taxscheme_novalue.txt Valid
taxscheme_missing.txt Invalid
josemmo added a commit that referenced this issue Jun 15, 2022
@josemmo
Fixed tax registration ID without scheme
b669eb9 
- Updated UblWriter class
- Updated unit tests

> Closes #26
@josemmo josemmo mentioned this issue Jun 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed tax registration ID without scheme josemmo/einvoicing
1 participant
@andras-minicrm