Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Negative PayableRoundingAmount #44

Closed
hallsten opened this issue Sep 2, 2023 · 1 comment · Fixed by #45
Closed

Negative PayableRoundingAmount #44

hallsten opened this issue Sep 2, 2023 · 1 comment · Fixed by #45
Labels
bug Something isn't working

Comments

@hallsten
Copy link

hallsten commented Sep 2, 2023

Thanks for a helpful library! Discovered a problem with RoundingAmount.

cbc:PayableRoundingAmount can be negative and positive, but the element only shows if the amount is positive. Suggest changing line 831 in UblWriter.php from:
if ($totals->roundingAmount > 0) {

to:
if ($totals->roundingAmount <> 0) {

Many thanks

@josemmo josemmo added the bug Something isn't working label Sep 9, 2023
@josemmo
Copy link
Owner

josemmo commented Sep 9, 2023

@hallsten, thanks for the reporting this! Will fix it in the next release.

josemmo added a commit that referenced this issue Sep 9, 2023
- Updated UblWriter class

> Closes #44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants