Skip to content

Commit

Permalink
Edge: review actionn (limit notificaiton context to Edge). Re nvacces…
Browse files Browse the repository at this point in the history
…s#8423.

Reviewed by @LeonarddeR: limit Edge notificaiton context to Edge only. This is done by checking to make sure focused element is indeed part of Edge, and if not, notifications will be silenced. This resolves an issue where Edge notifications are heard while using other apps.
  • Loading branch information
josephsl committed Jun 21, 2018
1 parent efc4182 commit 1134440
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion source/appModules/microsoftedge.py
Expand Up @@ -7,11 +7,15 @@
"""appModule for Microsoft Edge main process"""

import appModuleHandler
import api
import ui

class AppModule(appModuleHandler.AppModule):

def event_UIA_notification(self, obj, nextHandler, displayString=None, **kwargs):
# #8423: even though content process is focused, notifications are fired by main Edge process.
# The base object will simply ignore this, so notifications must be announced here and no more.
ui.message(displayString)
# And no, notifications should be limited to Edge context - that is, focused item is part of Edge (both main and content processes).
if api.getFocusObject().appModule.appName.startswith("microsoftedge"):
ui.message(displayString)

0 comments on commit 1134440

Please sign in to comment.