Add-on updates dialog: display add-on update results dialog on startu…

…p if told to do so via a callback. Re nvaccess#3208.

Possibly due to threading issue: GUI works correctly if queued from the main thread. One way to do this is via a callback that is claled by wx.CallAfter. Thus use an internal callback when NVDA needs to display add-on update results dialog at startup.

source/addonHandler.py

@@ -156,14 +156,19 @@ def autoAddonUpdateCheck():
 	t.start()
 
 def _showAddonUpdateUI():
+	def _showAddonUpdateUICallback(info):
+		# The only purpose of this callback is to force add-on updates window to show up at startup.
+		import gui
+		from gui.addonGui import AddonUpdatesDialog
+		gui.mainFrame.prePopup()
+		AddonUpdatesDialog(gui.mainFrame, info).Show()
+		gui.mainFrame.postPopup()
 	try:
 		info = checkForAddonUpdates()
 	except:
 		info = None
 	if info is not None:
-		import gui
-		from gui.addonGui import AddonUpdatesDialog
-		wx.CallAfter(AddonUpdatesDialog, gui.mainFrame, info)
+		wx.CallAfter(_showAddonUpdateUICallback, info)
 
 def initialize():
 	""" Initializes the add-ons subsystem. """