Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extrema() only available for Date time types #20

Closed
brucala opened this issue Jun 20, 2020 · 1 comment
Closed

Extrema() only available for Date time types #20

brucala opened this issue Jun 20, 2020 · 1 comment

Comments

@brucala
Copy link
Contributor

brucala commented Jun 20, 2020

extrema_init(T::Type{Date}) = typemax(Date), typemin(Date), Union{Date, Dates.AbstractDateTime}

As I understand from the code above, it looks like Extrema() only works for Date time types. Is there a reason for not extending to a generic TimeType?
For instance replacing the code to something like:

extrema_init(T::Type{<:TimeType}) = typemax(T), typemin(T), TimeType
@joshday
Copy link
Owner

joshday commented Jun 20, 2020

Is there a reason for not extending to a generic TimeType?

Only that my use case was for Date when I was implementing it.

Fixed on master! New release pending. Thanks for the issue!

@joshday joshday closed this as completed Jun 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants