Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap nav and nav2? #3

Closed
RadLikeWhoa opened this issue Nov 28, 2012 · 6 comments
Closed

Swap nav and nav2? #3

RadLikeWhoa opened this issue Nov 28, 2012 · 6 comments
Assignees
Labels

Comments

@RadLikeWhoa
Copy link
Contributor

Although I agree with you preferring the inline-block method to display a list horizontally, floated lis are by far more common. I don't know if you agree with me, but I'd say having the more common variant as the primary method is preferable. If people really want to use the inline-block method as default, they can still change the snippets manually.

@joshnh
Copy link
Owner

joshnh commented Nov 28, 2012

Yeah, I had considered that. I might try and come up with another naming convention, as nav2 isn't ideal anyway.

@RadLikeWhoa
Copy link
Contributor Author

I don't know the whole Sublime development stuff well enough, but is there a way to have settings for the snippets? Users could choose the nav markup they want and also activate/deactivate certain snippets. Would probably be easiest if further issues like this come up.

@joshnh
Copy link
Owner

joshnh commented Nov 28, 2012

Not really. Sublime Text just reads a bunch of files that are in it's packages folder. The only way to 'turn off' snippets is to remove them from the packages folder.

@RadLikeWhoa
Copy link
Contributor Author

Another option would be to remove nav2, ul and ol entirely and let Zen Coding/Emmet handle it as the number of list items is unknown anyway. nav has the benefit of commenting out the whitespace, which would not be possible with Emmet so it has good reason to stay in.

@joshnh
Copy link
Owner

joshnh commented Nov 28, 2012

I'd like to have this as independent as possible, so I'd rather not rely on another package, even one as amazing as Emmet.

@joshnh
Copy link
Owner

joshnh commented Nov 28, 2012

I've renamed the nav snippets to make more sense (e723e5b).

@joshnh joshnh closed this as completed Nov 28, 2012
@ghost ghost assigned joshnh Nov 29, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants