Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple colons #82

Closed
hsheth2 opened this issue Sep 22, 2023 · 2 comments · Fixed by #85
Closed

Multiple colons #82

hsheth2 opened this issue Sep 22, 2023 · 2 comments · Fixed by #85

Comments

@hsheth2
Copy link

hsheth2 commented Sep 22, 2023

This is a fun one - turns out Looker is accepting of lkml code that has multiple colon (:) characters in a row, possibly with spaces between.

This works in both measure/dimension definitions and in value_format, and probably in other places too.

view: my_view {
  # other stuff

  measure: :: ::::: my_measure {
    type: number
    value_format:: : "0.00%"
  }
}

The current lkml parser (v1.3.1) throws an exception on this input.

@joshtemple
Copy link
Owner

Hey @hsheth2! I'm not sure how I feel about supporting these odd idiosyncrasies of the Looker parser. How does lkml not supporting this kind of syntax affect your usage of the tool?

@hsheth2
Copy link
Author

hsheth2 commented Sep 26, 2023

@joshtemple it's not a huge deal - this isn't a super common bug, but it does come up. Folks find it confusing because the Looker UI's "validate lookml" button says everything is good, but then we fail to parse their files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants