Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚀 Feature: --mode migrate should prompt for the base #1376

Open
2 tasks done
JoshuaKGoldberg opened this issue Mar 7, 2024 · 0 comments
Open
2 tasks done

🚀 Feature: --mode migrate should prompt for the base #1376

JoshuaKGoldberg opened this issue Mar 7, 2024 · 0 comments
Labels
status: accepting prs Please, send a pull request to resolve this! type: feature New enhancement or request

Comments

@JoshuaKGoldberg
Copy link
Owner

JoshuaKGoldberg commented Mar 7, 2024

Bug Report Checklist

Overview

Splitting out of #1355: running npx create-typescript-app --mode migrate doesn't explicitly call out what the inferred --base is on. You can only see it by looking at the rerun suggestion.

●  Tip: to run again with the same input values, use: npx create-typescript-app --mode migrate --base minimum --access public --author danvk --description "Code samples that scale" --directory literate-ts --email-github danvdk@gmail.com --email-npm danvdk@gmail.com --mode migrate --owner danvk --repository literate-ts --title "Literate TS"

...but that leads to broken expectations when the inferred base doesn't match what the user would expect. And if it defaults to --base minimum, that's a lot of missing functionality!

Migration should prompt the user for the --base. I was surprised to see it default to minimum.

Additional Info

Co-authored-by: @danvk

@JoshuaKGoldberg JoshuaKGoldberg added type: feature New enhancement or request status: accepting prs Please, send a pull request to resolve this! labels Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: accepting prs Please, send a pull request to resolve this! type: feature New enhancement or request
Projects
None yet
Development

No branches or pull requests

1 participant