Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign up280 remove file io #281
280 remove file io #281
Conversation
bring fork up to date
This reverts commit 09dbb0e.
repalced all for download.file and curl_fetch_disk. left calls in loadSymbol.r alone
|
Hi @ethanbsmith, thanks for working on this PR! Is it ready for review? |
|
Yes.
…________________________________
From: Joshua Ulrich <notifications@github.com>
Sent: Saturday, October 26, 2019 5:52:25 AM
To: joshuaulrich/quantmod <quantmod@noreply.github.com>
Cc: Ethan Smith <ethan.smith@pobox.com>; Mention <mention@noreply.github.com>
Subject: Re: [joshuaulrich/quantmod] 280 remove file io (#281)
Hi @ethanbsmith<https://github.com/ethanbsmith>, thanks for working on this PR! Is it ready for review?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#281?email_source=notifications&email_token=AF2ACB62STXTPOXA2324C4LQQQVPTA5CNFSM4JB6QN22YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECKGILA#issuecomment-546595884>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AF2ACB7A6KVJGEBELPEZU4DQQQVPTANCNFSM4JB6QN2Q>.
|
1739987
into
joshuaulrich:master
removed disk i/o from critical path of functions that fetch data form the internet. these functions now operate entirely in memory
main drivers for this:
Fixes #280