Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reporting isVisible for free element #50

Closed
skovhus opened this issue Oct 13, 2016 · 4 comments · Fixed by #114
Closed

Reporting isVisible for free element #50

skovhus opened this issue Oct 13, 2016 · 4 comments · Fixed by #114

Comments

@skovhus
Copy link

skovhus commented Oct 13, 2016

For elements that do not have a size in the DOM, react-visibility-sensor currently reports that it is visible.

I think this should be the first check:

if (rect.top + rect.right + rect.bottom + rect.left + rect.width === 0) {
  isVisible = false;
}
skovhus pushed a commit to skovhus/react-visibility-sensor that referenced this issue Oct 13, 2016
skovhus pushed a commit to skovhus/react-visibility-sensor that referenced this issue Oct 13, 2016
@joshwnj
Copy link
Owner

joshwnj commented Nov 24, 2016

@skovhus good idea, and thanks for the PR! I'll get to it soon I promise :)

skovhus pushed a commit to skovhus/react-visibility-sensor that referenced this issue Dec 15, 2016
@neeharv
Copy link
Collaborator

neeharv commented Dec 19, 2016

Awesome lib @joshwnj! Any timeframe on getting this into a release? Would be super helpful 👍

@joshwnj
Copy link
Owner

joshwnj commented Dec 19, 2016

thanks @neeharv . We're nearly ready to release this, just need to do some final reviews of #51

If you're able to help by pulling that branch and making sure things still work as expected, that will speed up the process a lot :)

@ryan-foster-ck
Copy link

What's the status/future of this patch? Anyway I can help get it across the line?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants