Check if the component has size and is not hidden #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @runmoore - good solution. |
|
published @ 3.13.0 |
This was referenced Aug 31, 2018
This was referenced Sep 21, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if the component being checked is hidden (e.g.
display: none) or just doesn't have a size theisVisibleflag is being incorrectly set totrueThis fixes #50 and possibly satisfys #58 's problem.
#50 already has a PR open (#51 by @skovhus ), but it's been around since October 2016 and has open conflicts, so I've decided to resurrect the issue with a new PR with a hope to get it into a release soon 馃 It seems like multiple people (myself included) have run into this problem and would like a fix.