check if element has a size (#50)

[skovhus]

Fixes #50... Sorry that I didn't add any tests for this. Could be nice with some unit tests.

Maybe look at this with whitespace disabled: https://github.com/joshwnj/react-visibility-sensor/pull/51/files?w=0

[eek]

Can you remove the indentation changes?

[joshwnj]

Hi @skovhus , just wanted to touch base here. I'm keen to give your PR a proper review and merge but if you could first rebase & remove the whitespace changes it would really help. Thanks!

[skovhus]

I cannot release remove white space as the whole block is indented. Would be really great to refactor that giant function.

But I will rebase. ; )

[joshwnj]

Ah ok - yeah we do need to split up this giant function at some point :) I'm thinking of putting together a big major-version roadmap for early 2017, and this would definitely be on the cards.

I cannot release remove white space as the whole block is indented.

That's cool, but in that case could you please point out specifically what things you are changing? Just a bit difficult to see in the current diff :)

Thanks

[skovhus]

The diff without whitespace (?w=0) makes it fairly clear I think https://github.com/joshwnj/react-visibility-sensor/pull/51/files?w=0

But let me do an updated PR : )

[joshwnj]

Oh that is heaps better, thanks :) I have to remember that ?w=0 trick 😆

[skovhus]

I've updated the PR by rebasing with master, but I would like one of you to manually test this change.

More unit tests are required here in order to make a change like this safe.

[igorz-]

Hi! Could someone please tell when this will be merged? Or there are some better solution?

[joshwnj]

superceded by #114

[joshwnj]

Hi @igorz- & @skovhus, can you please check if the latest version is working for you? Thanks!