Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Public command that crashes the bot #84

Closed
truedesire opened this issue Sep 8, 2018 · 1 comment
Closed

Public command that crashes the bot #84

truedesire opened this issue Sep 8, 2018 · 1 comment

Comments

@truedesire
Copy link

truedesire commented Sep 8, 2018 •
edited
Loading

Public command "status" is crashes the bot.
"Segmentation fault [core dumped]"
Warcraft 1.28.5 (with constexpr int MAX_SLOTS = 12; in gameslot.h line 43
and packet.push_back(98); in bnetprotocol.cpp line 494)
Ubuntu 18.04 Bionic
Not sure about Warcraft 1.30
Josko added a commit that referenced this issue Sep 9, 2018
@Josko
bnet/game: Avoid crash when processing !status.
3e9d355 
As the IRC server is optional, so can the pointer be null.

Fixes #71 and #84.
@Josko
Copy link
Owner

Josko commented Sep 9, 2018

Thank you for the report!

@Josko Josko closed this as completed Sep 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Josko @truedesire