About _extractResponseCookies

[jet10000]

Today, I test requests for request django LoginView, the login success response 302 and the responseHeaders like:

{set-cookie: csrftoken=JXbDPUlqe3pJCxC3EHib4HT52WIFtpKeS63qsYMyehcVocrWUMIZeleUmBx1IZBj; expires=Wed, 06 Jan 2021 21:21:58 GMT; Max-Age=31449600; Path=/; SameSite=Lax,sessionid=58zhlb01kfqoa528efxpr4o75b02x76j; expires=Wed, 22 Jan 2020 21:21:58 GMT; HttpOnly; Max-Age=1209600; Path=/; SameSite=Lax, location: /, cache-control: max-age=0, no-cache, no-store, must-revalidate, private, date: Wed, 08 Jan 2020 21:21:58 GMT, vary: Cookie, content-length: 0, x-frame-options: DENY, content-type: text/html; charset=utf-8, x-content-type-options: nosniff, server: WSGIServer/0.2 CPython/3.7.6, expires: Wed, 08 Jan 2020 21:21:58 GMT}

I found SameSite=Lax,sessionid=58zhlb01kfqoa528efxpr4o75b02x76j;, and parser result not contains sessionid,only csrftoken=JXbDPUlqe3pJCxC3EHib4HT52WIFtpKeS63qsYMyehcVocrWUMIZeleUmBx1IZBj

Is this a django bug? or a requrests _extractResponseCookies bug?

[jet10000]

I use python requests, the response headers like:
('set-cookie', 'csrftoken=o082sC9furgSvorcIR2kLiEPA1eR7TqSQKPrWznTCLE8jIvYZuGrfjz6ryp8lALU; expires=Wed, 06 Jan 2021 23:39:59 GMT; Max-Age=31449600; Path=/; SameSite=Lax'), ('set-cookie', 'sessionid=su81gefosri54cy5a11f4tnsxp49a6n5; expires=Wed, 22 Jan 2020 23:39:59 GMT; HttpOnly; Max-Age=1209600; Path=/; SameSite=Lax')]

Maybe dart http library problem?

[jossef]

seems like a bug in _extractResponseCookies
it should not break on first match

requests/lib/src/requests.dart

Line 83 in a6d2371

break;

can you submit a PR with a fix?

[jet10000]

dart-lang/http#24

dart-lang/http#156