Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

_extractCookies when cookie has an equal sign #26

Closed
mirrari0 opened this issue Mar 30, 2020 · 1 comment
Closed

_extractCookies when cookie has an equal sign #26

mirrari0 opened this issue Mar 30, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@mirrari0
Copy link

We are using requests to handle our flutter http and found an issue in extractCookies. When a response cookie has an equals sign it, the existing split on "=" causes us to lose a portion of our cookie. IE

cookie1=qwerty-=?!2345

breaks into three parts

  1. cookie1
  2. qwerty-
  3. ?!2345

to work through this locally we are now splitting on the first instance of an =.
@jossef jossef added the bug Something isn't working label Apr 1, 2020
@jossef
Copy link
Owner

jossef commented Apr 1, 2020

Thanks for reporting. Can you submit a PR with a fix?

@jossef jossef closed this as completed in 7b2d34b May 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jossef @mirrari0