Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accept string values for width #165

Closed
JapMul opened this issue Sep 26, 2017 · 2 comments · May be fixed by #210
Closed

Accept string values for width #165

JapMul opened this issue Sep 26, 2017 · 2 comments · May be fixed by #210
Labels
enhancement

Comments

@JapMul
Copy link

JapMul commented Sep 26, 2017

Steps to reproduce the behavior:
Set width to width='50%'

Expected behavior:
max-width of the element will be set to 2%, without showing an error that the width can only be a number.

Actual behavior:
max-width of the element is set to 2%, but is showing an error that the width can only be a number.
@jossmac
Copy link
Owner

jossmac commented Feb 8, 2018 •
edited
Loading

Hi @JapMul!

This seems like a reasonable enhancement, any chance you could provide a PR?

Thanks in advance,
Joss

@JapMul
Copy link
Author

JapMul commented Feb 12, 2018

@jossmac Allright, I think I can provide a PR somewhere this week!

@JapMul JapMul mentioned this issue Feb 13, 2018
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Updated the width prop to include more valid CSS values.
3 participants
@neptunian @jossmac @JapMul