Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CCAPS - avoid overspecification of boundaries #52

Closed
JOThurgood opened this issue Nov 15, 2018 · 1 comment
Closed

CCAPS - avoid overspecification of boundaries #52

JOThurgood opened this issue Nov 15, 2018 · 1 comment

Comments

@JOThurgood
Copy link
Owner

The need to have vface bcs is just related to applying minmod at the very edge, otherwise the two ghosts for the sln vars should be enough to directly give you everything you need for the edge vars.

Add handling of the extreme case to minmod (just revert to a simple gradient there), and then change some of the loop sizes to capture the limits appropriately.

If you run with appropriate compiler flags, should check if OOB for you.

The simplification of boundary conditions should remove a number of possible sources of error/bugs and make the code easier to use.

@JOThurgood
Copy link
Owner Author

Are they actually over-specified?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant