Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow commit messages starting with "Bug 1234 -" #2

Closed
oleonard opened this issue May 18, 2017 · 1 comment
Closed

Allow commit messages starting with "Bug 1234 -" #2

oleonard opened this issue May 18, 2017 · 1 comment

Comments

@oleonard
Copy link
Contributor

When I write a commit message I typically copy and paste the bug title from Bugzilla, where a hyphen is the delimiter between the bug number and the title:

Bug 18584 - Our legacy code contains trailing-spaces

I think this should be allowed by the how-to.

@joubu
Copy link
Owner

joubu commented May 18, 2017

I agree with the hyphen, but what you describe is typically wrong:
The title of a bug report should describe the problem, here "Our legacy code contains trailing-spaces".
The commit message should describe what the patch does, here it "removes a trailing-space"

I'd also like to make consistent the use of "Bug 12345: " and "Bug 12345 - "

But yes I agree that the hyphen must be accepted for now.

@joubu joubu closed this as completed in bc043fb May 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants