Add support for Decred. #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wbobeirne
approved these changes
Sep 9, 2019
| @@ -3,7 +3,7 @@ export type Macaroon = string; | |||
|
|
|||
| export type Response<T> = Promise<T>; | |||
|
|
|||
| export type AddressType = 'np2wkh' | 'p2wkh'; | |||
| export type AddressType = '0' | '2'; | |||
There was a problem hiding this comment.
Ah thanks for this, wasn't sure why it didn't like these string args. This is likely a bug on LND's side, as they document it as being a string argument, and the CLI takes in those strings: https://api.lightning.community/rest/index.html#v1-newaddress
I would prefer these become enums so we're not passing around magic numbers, but I nothing that needs to happen in this PR.
There was a problem hiding this comment.
https://api.lightning.community/#addresstype
This is where I got the idea to try integers
| }, | ||
| testnet: { | ||
| tx: 'https://testnet.decred.org/tx/$TX_ID', | ||
| block: 'https://testnet.decred.org/block/$BLOCK_ID', |
There was a problem hiding this comment.
I noticed y'all don't have a privacy policy. Not merge blocking by any means, but it'd be nice to know if / how you're using user data when they visit your explorer.
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds full support for Decred.
Decred does not support p2wkh addresses as it already had a malleability fix upon launch. The only supported address type in dcrlnd right now is p2pkh, so this PR adds a AddressType for each supported currency to
utils/constants.ts. The AddressType is passed tonewaddressRPC.