Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚑 Fix reverse build #242

Open
wants to merge 2 commits into
base: v3/latest
Choose a base branch
from
Open

🚑 Fix reverse build #242

wants to merge 2 commits into from

Conversation

rubenaeg
Copy link
Contributor

Proposed changes

This PR fixes an issue with jovo build --reverse when using Dialogflow as a platform, where native files could not be located due to transforming locales to uppercase.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

@rubenaeg rubenaeg added Dialogflow Issues/PRs regarding Dialogflow functionality. v3 Issues/PRs for v3 of the Jovo CLI labels Sep 30, 2021
@rubenaeg rubenaeg added this to the 3.3.0 milestone Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jankoenig jankoenig jankoenig approved these changes

@aswetlow aswetlow aswetlow approved these changes

Assignees
No one assigned
Labels
Dialogflow Issues/PRs regarding Dialogflow functionality. v3 Issues/PRs for v3 of the Jovo CLI
Projects
None yet
Milestone
3.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@rubenaeg @jankoenig @aswetlow