Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Button property on table should be optional #1272

Closed
OriginalJef opened this issue Apr 6, 2022 · 2 comments
Closed

Button property on table should be optional #1272

OriginalJef opened this issue Apr 6, 2022 · 2 comments
Labels
help wanted

Comments

@OriginalJef
Copy link

jovo-framework/platforms/platform-googleassistant/src/output/models/content/Table.ts

Line 43 in 52912f7

button!: Link;

as listed in de docs, the button prop is optional:
https://developers.google.com/assistant/conversational/prompts-rich
@aswetlow
Copy link
Member

aswetlow commented Apr 7, 2022 •
edited

Thanks! Would you like to make a PR?

@aswetlow aswetlow assigned jankoenig and aswetlow and unassigned jankoenig and aswetlow Apr 7, 2022
aswetlow added a commit that referenced this issue Apr 25, 2022
@aswetlow
🐛 Make button property optional #1272
607ff09
@aswetlow aswetlow mentioned this issue Apr 25, 2022
Merged
8 tasks
aswetlow added a commit that referenced this issue Apr 25, 2022
@aswetlow
Merge pull request #1295 from jovotech/v4/fix/google-assistant-types
501cb71 
🐛 Make button property optional #1272
@jankoenig
Copy link
Member

Thanks for flagging this @OriginalJef. And for the fix @aswetlow 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jankoenig @aswetlow @OriginalJef