Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Fix google assistant capability #1274

Merged
merged 4 commits into from
Apr 25, 2022
Merged

🐛 Fix google assistant capability #1274

merged 4 commits into from
Apr 25, 2022

Conversation

kouz75
Copy link
Contributor

@kouz75 kouz75 commented Apr 12, 2022

Link with #1257
capabilities don't contains all informations

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

@jankoenig
Copy link
Member

Thank you @kouz75.

I see that you linked this PR with #1257, but I can't find the missing capabilities in your committed code. Is there something missing?

@kouz75 kouz75 changed the base branch from v4/latest to v4/dev April 14, 2022 13:08
@kouz75 kouz75 marked this pull request as draft April 14, 2022 13:08
@kouz75
Copy link
Contributor Author

kouz75 commented Apr 14, 2022

Hi

I reverted my changes and fix the incorrect code.

@kouz75 kouz75 marked this pull request as ready for review April 19, 2022 14:38
@kouz75 kouz75 closed this Apr 20, 2022
@kouz75 kouz75 reopened this Apr 20, 2022
@jankoenig jankoenig changed the title fix google assistant capability 🐛 Fix google assistant capability Apr 25, 2022
jankoenig
jankoenig approved these changes Apr 25, 2022
View reviewed changes
Copy link
Member

@jankoenig jankoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @kouz75 🎉

@jankoenig jankoenig merged commit 6379cac into jovotech:v4/dev Apr 25, 2022
@jankoenig jankoenig mentioned this pull request Apr 25, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jankoenig jankoenig jankoenig approved these changes

@aswetlow aswetlow aswetlow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kouz75 @jankoenig @aswetlow