Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Fix state stack merge on Google Assistant #1211 #1344

Merged
merged 2 commits into from
Jun 8, 2022
Merged

🐛 Fix state stack merge on Google Assistant #1211 #1344

merged 2 commits into from
Jun 8, 2022

Conversation

aswetlow
Copy link
Member

@aswetlow aswetlow commented Jun 7, 2022

Proposed Changes

Fixes mergeWith implementation in GoogleAssistantPlatform's finalizeResponse.

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

@aswetlow aswetlow requested a review from jankoenig June 7, 2022 18:53
jankoenig
jankoenig reviewed Jun 7, 2022
View reviewed changes
Copy link
Member

@jankoenig jankoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a comment so that we know at a later point why this has been added?

@aswetlow
Copy link
Member Author

aswetlow commented Jun 8, 2022

Thx, done.

@jankoenig jankoenig self-requested a review June 8, 2022 08:49
@jankoenig
Copy link
Member

Thanks!

@aswetlow aswetlow merged commit e7d05cc into v4/dev Jun 8, 2022
@aswetlow aswetlow deleted the v4/fix/google-state-merge branch June 8, 2022 09:13
@jankoenig jankoenig mentioned this pull request Jun 8, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jankoenig jankoenig jankoenig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aswetlow @jankoenig