Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Add sessionId to each Dashbot response #1471

Merged
merged 1 commit into from
Nov 30, 2022
Merged

🐛 Add sessionId to each Dashbot response #1471

merged 1 commit into from
Nov 30, 2022

Conversation

MathiasSchrooten
Copy link
Contributor

Proposed Changes

This commit adds the sessionId to the Dashbot response so that both request and response contain a sessionId, this ensures Dashbot links the incoming and outgoing messages to the same userId and sessionId (currently this does not always happen)

Types of Changes

  • [x ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Copy link
Member

@jankoenig jankoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you! looks good

@jankoenig jankoenig merged commit b818d04 into jovotech:v4/dev Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants