Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add unique request id for every request #1480

Merged
merged 2 commits into from
Jan 4, 2023
Merged

Conversation

aswetlow
Copy link
Member

@aswetlow aswetlow commented Jan 4, 2023

Proposed Changes

Adds $id property to the Jovo object which is a unique request id. The id is retrieved from the request payload or is a generated UUID v4, if the platform doesn't provide a request id.

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Copy link
Member

@jankoenig jankoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@aswetlow aswetlow merged commit 025f4ec into v4/dev Jan 4, 2023
@aswetlow aswetlow deleted the v4/feature/request-id branch January 4, 2023 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants