Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 fixed type of JovoHistoryItem.state #1538

Merged
merged 1 commit into from
Apr 24, 2023
Merged

🐛 fixed type of JovoHistoryItem.state #1538

merged 1 commit into from
Apr 24, 2023

Conversation

sadlowskij
Copy link
Contributor

Proposed Changes

I saw that JovoHistoryItem.state was unknown, due to a seemingly broken lookup type

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

aswetlow
aswetlow approved these changes Apr 24, 2023
View reviewed changes
Copy link
Member

@aswetlow aswetlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏 thank you

@aswetlow aswetlow requested a review from jankoenig April 24, 2023 11:29
@aswetlow aswetlow merged commit 5e9a1b2 into jovotech:v4/dev Apr 24, 2023
6 checks passed
@jankoenig jankoenig mentioned this pull request Apr 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jankoenig jankoenig jankoenig approved these changes

@aswetlow aswetlow aswetlow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sadlowskij @jankoenig @aswetlow