Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Add libraryConfig for LexRuntimeV2ClientConfig #1564

Merged
merged 1 commit into from
Jul 3, 2023
Merged

✨ Add libraryConfig for LexRuntimeV2ClientConfig #1564

merged 1 commit into from
Jul 3, 2023

Conversation

rmtuckerphx
Copy link
Contributor

Proposed Changes

  • Allow the use of Lex without explicitly setting credentials (AWS host).
  • Expose the entire LexRuntimeV2ClientConfig as libraryConfig.lexRuntimeV2Client.
  • Keep the change backward compatible by marking credentials and region as obsolete and if set, use them to override libraryConfig.lexRuntimeV2Client
  • Update README

Fix for issue:
#1563

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

jankoenig
jankoenig approved these changes Jul 3, 2023
View reviewed changes
Copy link
Member

@jankoenig jankoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Docs look great to me 👍🏻

@jankoenig jankoenig requested a review from aswetlow July 3, 2023 09:13
@jankoenig jankoenig merged commit 51d5dd0 into jovotech:v4/dev Jul 3, 2023
6 checks passed
@jankoenig jankoenig mentioned this pull request Jul 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jankoenig jankoenig jankoenig approved these changes

@aswetlow aswetlow aswetlow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rmtuckerphx @jankoenig @aswetlow