Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Fix undefined manifest information #1573

Merged
merged 1 commit into from Aug 8, 2023
Merged

🐛 Fix undefined manifest information #1573

merged 1 commit into from Aug 8, 2023

Conversation

acerbisgianluca
Copy link
Contributor

@acerbisgianluca acerbisgianluca commented Jul 9, 2023 •
edited

Proposed Changes

Use an empty object as default value for publishing info and privacy policy/TOS objects for Alexa build command.

resolves #1572

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

@aswetlow aswetlow self-requested a review August 8, 2023 11:30
@jankoenig jankoenig self-requested a review August 8, 2023 12:20
jankoenig
jankoenig approved these changes Aug 8, 2023
View reviewed changes
Copy link
Member

@jankoenig jankoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @acerbisgianluca!

@aswetlow aswetlow merged commit 54ad3ae into jovotech:v4/dev Aug 8, 2023
6 checks passed
@aswetlow aswetlow mentioned this pull request Aug 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jankoenig jankoenig jankoenig approved these changes

@aswetlow aswetlow aswetlow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@acerbisgianluca @jankoenig @aswetlow