Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 Fix bug #802

Merged
merged 2 commits into from Aug 10, 2020
Merged

Conversation

m-ripper
Copy link
Contributor

Proposed changes

Fix bug that would cause the values of the config file to not be considered for validation.
The validation now takes part when the plugin is being installed.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Fix bug that would cause the values of the config file to not be considered for validation
@aswetlow aswetlow merged commit 2af828c into jovotech:master Aug 10, 2020
@m-ripper m-ripper deleted the improvement/correct-validation branch August 14, 2020 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants