Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix bug related to audio in the request for CorePlatform and WebPlatform #879

Merged
merged 3 commits into from Jan 27, 2021

Conversation

m-ripper
Copy link
Contributor

@m-ripper m-ripper commented Dec 18, 2020

Proposed changes

Instead of parsing the audio-data in the request-middleware of CorePlatform, the parsing will now occur in the platform's respective core-module. This way we can assure that the parsing only happens if the request matches the platform.

closes #878

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

…ng to BufferArray

Moved into the $request-middleware of the Core-module. This way it will only be applied if the request matches the platform.
@m-ripper m-ripper linked an issue Dec 18, 2020 that may be closed by this pull request
4 tasks
@m-ripper m-ripper added Bug and removed Bug labels Dec 18, 2020
@aswetlow aswetlow merged commit 7011ff3 into jovotech:master Jan 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WebPlatform .audio Error on Echo Show 5 LAUNCH
2 participants