Bug: dictionary changed size during iteration

[foarsitter]

Somehow my models aren't completely loaded when the admin is initialized. During the setup of the admin fields are added to the model and therefore self.model.__dict__ changed size during iteration.

Fixing the problem is easier than isolating a test case, so I do not have something to reproduce the error.

• Starlette-Admin version: 0.13.2
• ORM/ODMs: SQLAlchemy

[jowilf]

Without a minimal reproducible example, we can't ensure that PR #508 effectively fixed the issue.

[foarsitter]

For now you have to believe me that this fixed my project :) For the foreseeable future I will update the PR but not in upcoming week.

[hasansezertasan]

For now you have to believe me that this fixed my project :) For the foreseeable future I will update the PR but not in upcoming week.

I think you should provide an example use case.

[foarsitter]

I'm unable to find the root cause and thus cannot provide a failing test case.

[nkhitrov]

I have the same error with association_proxy

class PreparationPhaseDB(MappedAsDataclass, BaseDB):
    __tablename__ = "preparation_phases"
    
	attachments: AssociationProxy[list[AttachmentDB]] = association_proxy(  # problem attr 
	        "attachments_relationship", "attachment", init=False
	    )
	 attachments_relationship: Mapped[list[PreparationPhaseAttachmentRelationDB]] = (
        relationship(lazy="noload", init=False)
    )
    
    
admin = Admin(engine=engine, ...)
admin.add_view(ModelView(PreparationPhaseDB, name="phases"))

 File "/Users/khitrov/Projects/ExamSimulator/exam-simulator-backend/exam_simulator/admin/admin.py", line 37, in create_admin_app
    admin.add_view(ModelView(PreparationPhaseDB, name="phases"))
                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/khitrov/.pyenv/versions/3.11.6/envs/exam-simulator/lib/python3.11/site-packages/starlette_admin/contrib/sqla/view.py", line 104, in __init__
    self._setup_primary_key()
  File "/Users/khitrov/.pyenv/versions/3.11.6/envs/exam-simulator/lib/python3.11/site-packages/starlette_admin/contrib/sqla/view.py", line 137, in _setup_primary_key
    for key in self.model.__dict__:
RuntimeError: dictionary changed size during iteration

[nkhitrov]

I change loop code

for key in self.model.__dict__.keys:

to

for key in list(self.model.__dict__.keys()):

and now it just works

[jowilf]

Great, thanks for sharing the fix. feel free to submit PR with your example as a test case