Skip to content
This repository has been archived by the owner on Jul 24, 2021. It is now read-only.

adjust expected output for GET /hardware_product #48

Merged
merged 1 commit into from
Jun 19, 2020
Merged

adjust expected output for GET /hardware_product #48

merged 1 commit into from
Jun 19, 2020

Conversation

karenetheridge
Copy link
Contributor

@karenetheridge karenetheridge added v3 Applies to V3 work high priority These issues should take preference labels Jun 16, 2020
@karenetheridge
Copy link
Contributor Author

A few unit tests fail (but not all!?) because of timezone mismatches:

: [ether@aquavit git/kosh]$; make
rm -rf bin
rm -rf release
staticcheck ./...
go test
--- FAIL: TestHarwareProductIntegration (0.00s)
    --- FAIL: TestHarwareProductIntegration/cli (0.00s)
        --- FAIL: TestHarwareProductIntegration/cli/create (0.00s)
            hardware_integration_test.go:122: Testing [kosh hardware products create --sku test-sku-001 --name Testy McTesterson --alias AJevFSyYbouRaBsPqggcDnEbC --vendor MyBigVendor --rack-unit-size 2 --validation-plan a30ab8b2-8a9e-4e51-8bb0-92862abd8b54 --purpose NKyPgWlJAatHcAaGxPiWxhZKR --bios-firmware oTyeRUaAPZJYrofJrzLzpwkhi --cpu-type DkTbSLFRjPFwORqKUTsoOEkvJ]
            hardware_integration_test.go:126: 
                	Error Trace:	hardware_integration_test.go:126
                	Error:      	Not equal: 
                	            	expected: "\nID: 9ad55ceb-2eb7-4125-a492-3c595277b3e3\nName: Testy McTesterson\nSKU: test-sku-001\n\nCreated: 2020-01-26 19:04:27 +0000 UTC\nUpdated: 2020-01-26 19:04:27 +0000 UTC\n\n"
                	            	actual  : "\nID: 9ad55ceb-2eb7-4125-a492-3c595277b3e3\nName: Testy McTesterson\nSKU: test-sku-001\n\nCreated: 2020-01-26 11:04:27 -0800 PST\nUpdated: 2020-01-26 11:04:27 -0800 PST\n\n"
                	            	
                	            	Diff:
                	            	--- Expected
                	            	+++ Actual
                	            	@@ -5,4 +5,4 @@
                	            	 
                	            	-Created: 2020-01-26 19:04:27 +0000 UTC
                	            	-Updated: 2020-01-26 19:04:27 +0000 UTC
                	            	+Created: 2020-01-26 11:04:27 -0800 PST
                	            	+Updated: 2020-01-26 11:04:27 -0800 PST
                	            	 
                	Test:       	TestHarwareProductIntegration/cli/create
        --- FAIL: TestHarwareProductIntegration/cli/product_SKU_get (0.00s)
            hardware_integration_test.go:122: Testing [kosh hardware product test-sku-001 get]
            hardware_integration_test.go:126: 
                	Error Trace:	hardware_integration_test.go:126
                	Error:      	Not equal: 
                	            	expected: "\nID: 9ad55ceb-2eb7-4125-a492-3c595277b3e3\nName: Testy McTesterson\nSKU: test-sku-001\n\nCreated: 2020-01-26 19:04:27 +0000 UTC\nUpdated: 2020-01-26 19:04:27 +0000 UTC\n\n"
                	            	actual  : "\nID: 9ad55ceb-2eb7-4125-a492-3c595277b3e3\nName: Testy McTesterson\nSKU: test-sku-001\n\nCreated: 2020-01-26 11:04:27 -0800 PST\nUpdated: 2020-01-26 11:04:27 -0800 PST\n\n"
                	            	
                	            	Diff:
                	            	--- Expected
                	            	+++ Actual
                	            	@@ -5,4 +5,4 @@
                	            	 
                	            	-Created: 2020-01-26 19:04:27 +0000 UTC
                	            	-Updated: 2020-01-26 19:04:27 +0000 UTC
                	            	+Created: 2020-01-26 11:04:27 -0800 PST
                	            	+Updated: 2020-01-26 11:04:27 -0800 PST
                	            	 
                	Test:       	TestHarwareProductIntegration/cli/product_SKU_get
FAIL
exit status 1
FAIL	github.com/joyent/kosh	0.149s
make: *** [test] Error 1

@karenetheridge karenetheridge mentioned this pull request Jun 18, 2020
Closed
@karenetheridge karenetheridge merged commit ff08d7d into master Jun 19, 2020
@karenetheridge karenetheridge deleted the ether/3.0-hwp branch June 19, 2020 16:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@perigrin perigrin perigrin approved these changes

Assignees
No one assigned
Labels
high priority These issues should take preference v3 Applies to V3 work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@karenetheridge @perigrin