This repository has been archived by the owner on Jul 24, 2021. It is now read-only.
Massive Refactor of Kosh's internals #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 30, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When kosh was first refactored from conch-shell it was the only go-based application talking to the API. So it made no sense to continue to maintain a separate package to wrap the upstream API. However going forward there will be more go based conch applications so having the conch library return is important.
This PR refactors kosh back into having an separate packages. It reworks the error handling to no longer use the panic/recover system, and it extracts the template and table rendering logic out into hopefully re-usable components as well.
User facing changes should be minimal. Some places where kosh was pulling a lot of information for output have been streamlined (temporarily) until we have better feedback on what information we need from those commands. Also some of the command shortcuts from conch-shell have been restored because finger memory is a thing.