This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
build: fix make install and out/doc/api%.html in BUILDTYPE=Debug #2615
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is reported in Japanese NodeJS ML that installing of 0.7.1 with nave is failed.
This is because nave builds and installs node with "./configure --debug ; make; make install" and GYP in 0.7.x only build out/Debug while WAF in 0.6.x build both out/Debug and out/Release.
It might be an issue of nave but I think it is worth to fix this in the node side to be compatible with the build behaviors between 0.6.x and 0.7.x
Before applying this patch, it fails to make install after configure --debug as below
Bfter applying this patch, the Release build is checked before make install and install was completed fine.