Just removed that smelly code. #27

Merged
merged 1 commit into from Jul 9, 2012

Conversation

Projects
None yet
3 participants
@budnik

budnik commented Jul 9, 2012

I've tesed it on a sandbox - seems like PAYPAL doesn't care about headers case. Just like RFC says it should.

jpablobr added a commit that referenced this pull request Jul 9, 2012

Merge pull request #27 from dmitriybudnik/master
Just removed that smelly code.

@jpablobr jpablobr merged commit f21aec0 into jpablobr:master Jul 9, 2012

@saizai

This comment has been minimized.

Show comment Hide comment
@saizai

saizai Jul 11, 2012

Contributor

I'm confused. How does this change make it case insensitive?

Contributor

saizai commented on fa41ad8 Jul 11, 2012

I'm confused. How does this change make it case insensitive?

This comment has been minimized.

Show comment Hide comment

This comment has been minimized.

Show comment Hide comment
@saizai

saizai Jul 11, 2012

Contributor

… are we looking at the same commit?

I see one that's just 12 deleted lines, so it's not clear how this could add insensitivity.

It doesn't have the word 'downcase' in it anywhere, whereas the Ruby you quoted has key.downcase.

Contributor

saizai replied Jul 11, 2012

… are we looking at the same commit?

I see one that's just 12 deleted lines, so it's not clear how this could add insensitivity.

It doesn't have the word 'downcase' in it anywhere, whereas the Ruby you quoted has key.downcase.

This comment has been minimized.

Show comment Hide comment
@jpablobr

jpablobr Jul 11, 2012

Owner

To me seems like ruby will downcase the key parameter sent to the []= method so it can maybe have a better chance at matching that header key... but that's my guess... :/

Owner

jpablobr replied Jul 11, 2012

To me seems like ruby will downcase the key parameter sent to the []= method so it can maybe have a better chance at matching that header key... but that's my guess... :/

This comment has been minimized.

Show comment Hide comment
@saizai

saizai Jul 11, 2012

Contributor
Contributor

saizai replied Jul 11, 2012

This comment has been minimized.

Show comment Hide comment
@jpablobr

jpablobr Jul 11, 2012

Owner

I don't remember 😞 but I think it had something to do with the way PayPal was validating headers.

Owner

jpablobr replied Jul 11, 2012

I don't remember 😞 but I think it had something to do with the way PayPal was validating headers.

This comment has been minimized.

Show comment Hide comment
@saizai

saizai Jul 11, 2012

Contributor

Does PP think they're case sensitive? If yes, RFC or no, then they effectively are…

Contributor

saizai replied Jul 11, 2012

Does PP think they're case sensitive? If yes, RFC or no, then they effectively are…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment