Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XSS vulnerability_1 #1477

Closed
xjzzzxx opened this issue Jul 9, 2024 · 3 comments
Closed

XSS vulnerability_1 #1477

xjzzzxx opened this issue Jul 9, 2024 · 3 comments
Labels

Comments

@xjzzzxx
Copy link

xjzzzxx commented Jul 9, 2024

Hello,

I would like to report for a xss vulnerability in openflights.

The path of the vulnerability.

In file https://github.com/jpatokal/openflights/blob/master/php/settings.php

$type = $_POST["type"];		//Line 6
...
die("0;" . sprintf(_("Unknown action %s"), $type));		//Line 60

We see that there is no check between the input $_POST["type"] and the output(Line 60)

Thus the XSS will happen at die("0;" . sprintf(_("Unknown action %s"), $type));

Poc:

POST type=<script>alert('xss')</script>

Manual verification:
1

2

@ouuan
Copy link
Contributor

ouuan commented Jul 21, 2024

It seems that the maintainers don't care much about security:

image

Only the most critical two are silently fixed.

@ouuan
Copy link
Contributor

ouuan commented Jul 21, 2024

Have you tried reaching out to the maintainers in private? It's generally best to avoid publicly disclosing security vulnerabilities initially. Instead, we should report them privately and give the maintainers a chance to respond and address the issues. If they don't respond or fail to coordinate on fixing the problems, then full disclosure might be considered. However, since I have already attempted this, public disclosure is probably acceptable now.

@ouuan
Copy link
Contributor

ouuan commented Jul 21, 2024

@xjzzzxx Well, I just checked your profile and saw a bunch of public issues about security vulnerabilities. I guess you should take a look at how responsible disclosure works.

@reedy reedy added the bug label Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants