Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blacklist should filter on whole words #43

Closed
jpchip opened this issue Mar 31, 2019 · 7 comments
Closed

Blacklist should filter on whole words #43

jpchip opened this issue Mar 31, 2019 · 7 comments
Assignees
Labels
bug Something isn't working

Comments

@jpchip
Copy link
Owner

jpchip commented Mar 31, 2019

It's a shame you are stripping the spaces...I would just separate by the command and grab the strings asis. Anyway I ended up having to pull "bra" and a few others that ended up blocking unexpected sweeps.

Originally posted by @famewolf in #22 (comment)

@jpchip jpchip self-assigned this Mar 31, 2019
@jpchip jpchip added the bug Something isn't working label Mar 31, 2019
@jpchip
Copy link
Owner Author

jpchip commented Apr 1, 2019

@famewolf Latest release includes this. Only whole words (or multiple words) are supported now.

@jpchip jpchip closed this as completed Apr 1, 2019
@famewolf
Copy link

famewolf commented Apr 6, 2019

Do you know a simple method to get a list of all the sweeps titles to be used to configure the blacklist?

@jpchip
Copy link
Owner Author

jpchip commented Apr 6, 2019

Well, you theoretically could write a script to make puppeteer go through every page and get the titles of all the giveways on those pages. Not sure how else you would get them...

@famewolf
Copy link

famewolf commented Apr 6, 2019

I'll think on a shell script using wget to grab the html and see if I can extract the title to a file. Think I'll google first to see if anyone else has come up with something.

@famewolf
Copy link

famewolf commented Apr 6, 2019

Well that didn't take long: https://giveawaylisting.com This page may be of interest to you as it shows the odds of winning as well as the max # of winners. Farther down the line it might pay to prioritize on listings with the best odds/most winners.

@jpchip
Copy link
Owner Author

jpchip commented Apr 6, 2019

Nice, that's a great find! Could definitely use that for #33.

@famewolf
Copy link

If you supported * wildcards it would handle both "newborn" and "newborns" with one entry. Something to consider?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants