Select reactivity #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the way through and returns something not null.
…rsion of the current generate_* functions, and probably best to use for everything else too for more realistic plots.
… complexity) Add tests for mod_token_plot server and UI
…e_data() to two objects temporarily
…ivity and reducing complexity somewhat + moving the elements from app_server.R -> mod_umap_plot. Which may be split into the plotting and the filtering still.
…te is pressed, and now all the modules should behave as expected
This was referenced Nov 14, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
re-organising the structure of app_server (reducing complexity) to fix some sticky reactivity issues + adding tests for modules whose functionality has been updated.