Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run vespa excluding some scenarios #3

Open
john-livingston opened this issue Sep 4, 2021 · 3 comments
Open

run vespa excluding some scenarios #3

john-livingston opened this issue Sep 4, 2021 · 3 comments

Comments

@john-livingston
Copy link
Collaborator

Given the recent discussion about triceratops, I remembered we can do the same with vespa like what Luke did:

https://github.com/lgbouma/timmy/blob/master/drivers/vespa_drivers/run_simple.py

@jpdeleon
Copy link
Owner

I haven't excluded scenarios yet but I just re-ran vespa using additional Gemini contrast curves taken in 2021-10-14.

Compared to before, the after results show smaller FPP as expected.

@jpdeleon
Copy link
Owner

jpdeleon commented Jan 28, 2022

Luke added the method FPPhack in calcfpp.py

https://github.com/lgbouma/timmy/blob/5ff7c0df27e22dd9343933b26b05f7f0468c00d8/drivers/vespa_drivers/run_simple.py#L189

which is likely a hacked version of the original FPPplots method:

https://github.com/timothydmorton/VESPA/blob/0446b54d48009f3655cfd1a3957ceea21d3adcaa/vespa/fpp.py#L375

Since his FPPhack version is not in his repo, I can only guess what it does from the given arguments which is just skipping models while adding tags on the final FPPSummary figure. However, the skipmodels argument in FPPhack method does not fit in the original FPPplots method.

@john-livingston
Copy link
Collaborator Author

How about just hacking the vespa output you already have to exclude the desired scenarios?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants