Skip to content
This repository has been archived by the owner on Aug 7, 2020. It is now read-only.

Make Default Artist Key Configurable #26

Open
JPDSousa opened this issue Aug 15, 2018 · 0 comments
Open

Make Default Artist Key Configurable #26

JPDSousa opened this issue Aug 15, 2018 · 0 comments

Comments

@JPDSousa
Copy link
Owner

In format parser (AbstractArtistField), a default key is hardcoded as a base key to be used when creating artists from field values.

The problem is that we can only extract the artist name from the field value, whereas there are more required values that cannot be inferred at this stage. This leads to the ArtistKey being "filled" with incorrect values, which goes against the idea of having those fields required.

The only approach here (AFAIK) is to give as much power to the user as we can:

  • Let the user define if a default key will be used. If not, the artist inference will always fail, as long as we do not implement a fallback mechanism;
  • Let the user define the default values for each key.

Both options will be defined through a Config-based type. Also, note that this is not a muttex situation, as we can perfectly combine both options.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant