Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong maximum value for bossbar when target TPS is not 20 #114

Open
msbmteam opened this issue Feb 24, 2024 · 0 comments · May be fixed by #149
Open

Wrong maximum value for bossbar when target TPS is not 20 #114

msbmteam opened this issue Feb 24, 2024 · 0 comments · May be fixed by #149
Labels
bug Something isn't working

Comments

@msbmteam
Copy link

When displaying TPS information using the bossbar, the maximum value of the bossbar always corresponds to 50 ms even when using the "/tick rate" command to change the server's TPS to a value other than 20. /tick rate is a vanilla command, so this mod should be able to handle it.

To Reproduce
Steps to reproduce the behavior:

  1. Toggle bossbar using /tabtps toggle bossbar
  2. Set the target tick rate to a number significantly greater than 20, e.g. /tick rate 60

Expected behavior
When I set the tick rate to 60, I would expect the bossbar maximum to correspond to 16.667 ms, but the maximum still corresponds to 50 ms

Screenshots
In the screenshot below, I would expect the bar to be about half full and yellow, but it is only about 16% full and green
2024-02-24_15 49 29

Server Software and Version:

  • Running a Fabric server with TabTPS installed
  • Minecraft Version: 1.20.4
  • TabTPS version: 1.3.22
@msbmteam msbmteam added the bug Something isn't working label Feb 24, 2024
@jpenilla jpenilla linked a pull request Jul 24, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant