Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyproject.toml support #23

Open
Olegt0rr opened this issue May 4, 2022 · 4 comments
Open

pyproject.toml support #23

Olegt0rr opened this issue May 4, 2022 · 4 comments

Comments

@Olegt0rr
Copy link

Olegt0rr commented May 4, 2022

Please, add pyproject.toml support

@mscheltienne
Copy link

+1 for this!

@mscheltienne
Copy link

Is it actually not supported?

      - name: Run mypy
        uses: jpetrucciani/mypy-check@master
        with:
          path: './mne_icalabel'
          mypy_flags: '--config-file pyproject.toml'

That seems to work fine.

@anton-buyskikh
Copy link

Perhaps the best experience would be if the action followed the defaults of mypy istself, which is described on the top of https://mypy.readthedocs.io/en/stable/config_file.html :

Mypy supports reading configuration settings from a file. By default it uses the file mypy.ini with a fallback to .mypy.ini, then pyproject.toml, then setup.cfg in the current directory, then $XDG_CONFIG_HOME/mypy/config, then ~/.config/mypy/config, and finally .mypy.ini in the user home directory if none of them are found; the --config-file command-line flag can be used to read a different file instead (see Config file).

@gaby
Copy link

gaby commented May 31, 2023

@jpetrucciani Any updates on this? I tried using the yaml from @mscheltienne but it doesnt install dependencies

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants