Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update druid to fix compilation for windows target #322

Closed
xtenduke opened this issue Aug 9, 2022 · 1 comment
Closed

Update druid to fix compilation for windows target #322

xtenduke opened this issue Aug 9, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@xtenduke
Copy link

xtenduke commented Aug 9, 2022

Describe the bug
Psst doesn't compile on windows because the targeted commit of the druid fork has an issue which was fixed here
linebender/druid#2238

PS C:\Users\Jake\development\psst>cargo build
   Compiling ureq v2.4.0
   Compiling druid-shell v0.7.0 (https://github.com/jpochyla/druid?branch=psst#4cfcf6e1)
error[E0432]: unresolved import `raw_window_handle::windows::WindowsHandle`
  --> C:\Users\Jake\.cargo\git\checkouts\druid-64a54200c8cd3ebf\4cfcf6e\druid-shell\src\backend\windows\window.rs:51:25
   |
51 | use raw_window_handle::{windows::WindowsHandle, HasRawWindowHandle, RawWindowHandle};
   |                         ^^^^^^^^^-------------
   |                         |        |
   |                         |        help: a similar name exists in the module: `Win32Handle`
   |                         no `WindowsHandle` in `windows`

error[E0603]: module `windows` is private
  --> C:\Users\Jake\.cargo\git\checkouts\druid-64a54200c8cd3ebf\4cfcf6e\druid-shell\src\backend\windows\window.rs:51:25
   |
51 | use raw_window_handle::{windows::WindowsHandle, HasRawWindowHandle, RawWindowHandle};
   |                         ^^^^^^^ private module
   |
note: the module `windows` is defined here
  --> C:\Users\Jake\.cargo\registry\src\github.com-1ecc6299db9ec823\raw-window-handle-0.4.2\src\lib.rs:30:1
   |
30 | mod windows;
   | ^^^^^^^^^^^^

error[E0599]: no variant or associated item named `Windows` found for enum `RawWindowHandle` in the current scope
   --> C:\Users\Jake\.cargo\git\checkouts\druid-64a54200c8cd3ebf\4cfcf6e\druid-shell\src\backend\windows\window.rs:196:30
    |
196 |             RawWindowHandle::Windows(handle)
    |                              ^^^^^^^ variant or associated item not found in `RawWindowHandle`

error[E0599]: no variant or associated item named `Windows` found for enum `RawWindowHandle` in the current scope
   --> C:\Users\Jake\.cargo\git\checkouts\druid-64a54200c8cd3ebf\4cfcf6e\druid-shell\src\backend\windows\window.rs:199:30
    |
199 |             RawWindowHandle::Windows(WindowsHandle::empty())
    |                              ^^^^^^^ variant or associated item not found in `RawWindowHandle`

Some errors have detailed explanations: E0432, E0599, E0603.
For more information about an error, try `rustc --explain E0432`.
error: could not compile `druid-shell` due to 4 previous errors

To Reproduce
Build Psst on Windows

Expected behavior
Building Psst on windows should succeed

Screenshots
n/a

Environment

  • OS: Windows
  • Version: 10 21H2
@xtenduke xtenduke added the bug Something isn't working label Aug 9, 2022
@liquiddandruff
Copy link

Looks good to close I think, fixed in upstream and submodule has been updated. Was able to build recently

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants