Enable environment property replacement anywhere #554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In `QFactory`'s tests for environment properties replacement. Signed-off-by: Andrés Alcarraz <alcarraz@gmail.com>
|
I removed the draft flag, because I added the verbatim tests. However, I'm not entirely convinced on performing the replacement in the |
Credit to @apr. - Don't call the method in `instantiate`, since there, it is more of a secondary effect. - Instead, call the property expansion method before instantiate in `Q2.deploy` file to better express the intent. Signed-off-by: Andrés Alcarraz <alcarraz@gmail.com>
|
Once this PR is merged, I commit myself to add something on the programmer's guide, documenting this. |
ar
approved these changes
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This draft PR is a possible implementation of what's discussed in #546.
When an element is instantiated via
QFactory.instantiatethe element is passed to the addedreplaceEnvPropertiesmethod, which replaces all environment properties recursively on its children and its attributes.If an element has the
verbatimattribute set totrueit will not process it or its children, I'm inclined to think this should be the correct behavior because it also acts as a performance hint to not recursively process its children. However, one may expect to override the parent's option in a child, so this is debatable. This also simplifies the code, by not having to track changes in the attribute down the line in the recursion.It may be necessary to remark that the
verbatimoption does not apply to theConfigurationelements or other classes that callEnvironment.getPropertyon its own. This may sound obvious, but some may get confused about that.