Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable environment property replacement anywhere #554

Merged
merged 4 commits into from
Jul 28, 2023
Merged

Enable environment property replacement anywhere #554

merged 4 commits into from
Jul 28, 2023

Commits on Jul 20, 2023

  1. Enable environment property replacement anywhere

    @alcarraz
    alcarraz committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    ee8f1fe View commit details
    Browse the repository at this point in the history

  2. Remove some linter errors

    @alcarraz
    alcarraz committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    623ca9c View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2023

  1. Added test cases for verbatim 

    In `QFactory`'s tests for environment properties replacement.

Signed-off-by: Andrés Alcarraz <alcarraz@gmail.com>
    @alcarraz
    alcarraz committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    1698b3c View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2023

  1. Better naming for method that expands properties. 

    Credit to @apr.

- Don't call the method in `instantiate`, since there, it is more of a secondary effect.
- Instead, call the property expansion method before instantiate in `Q2.deploy`
file to better express the intent.

Signed-off-by: Andrés Alcarraz <alcarraz@gmail.com>
    @alcarraz
    alcarraz committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    4b3b0b9 View commit details
    Browse the repository at this point in the history