Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Bitbucket support #16

Open
jihonrado opened this issue Mar 17, 2017 · 1 comment
Open

Add Bitbucket support #16

jihonrado opened this issue Mar 17, 2017 · 1 comment

Comments

@jihonrado
Copy link

jihonrado commented Mar 17, 2017

This library works only with Github with the current implementation, as it uses URLs like this:

https://circleci.com/api/v1.1/project/:username/:project/tree/:branch

Following the documentation, the VCS can be specified by using URLs like:

https://circleci.com/api/v1.1/project/:vcs-type/:username/:project/tree/:branch

Not providing the vcs-type path parameter makes CircleCI consider github as VCS.

A way to fix this would be to add the vcs-type config value and using it in the functions where it is needed.

/cc @jpstevens

@jpstevens
Copy link
Owner

Hi @jihonrado, I like the idea, but would have to make sure it's backwards compatible.

Did you have something like the following in mind:

ci.getBuilds({ username: "username", project: "product", vcsType: "github", branch: "master" })
.then(function (builds) { ... });

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants