Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

repo incorrectly runs pager #19

Closed
GoogleCodeExporter opened this issue Aug 21, 2015 · 2 comments
Closed

repo incorrectly runs pager #19

GoogleCodeExporter opened this issue Aug 21, 2015 · 2 comments

Comments

@GoogleCodeExporter
Copy link

Reported by Jean-Baptiste Queru <jbq@google.com> on Tue Mar 31 21:02:35 PDT 2009
Source: JIRA REPO-19

The repo script uses pager, and inherently will produce control character
(coloring) to standard output, even if the output is redirected to another
pipe or script.

This is because the script checks for the terminal presence on FD 0, and in
case of redirection FD 0 is still attached to the terminal.

.repo/repo/pager.py needs to be modified to fix this, replacing isatty(0)
with isatty(1). (Probably, it should be not os.isatty(0) or not os.isatty(1))

(see also http://b.android.com/2004 for original issue)

Original issue reported on code.google.com by code-rev...@gtempaccount.com on 24 Sep 2009 at 9:09

@GoogleCodeExporter
Copy link
Author

Comment by Shawn Pearce <sop@google.com> on Wed Apr 01 07:27:48 PDT 2009

Fixed by https://review.source.android.com/9453 (repo 1.6.4)

Original comment by code-rev...@gtempaccount.com on 24 Sep 2009 at 9:10

@GoogleCodeExporter
Copy link
Author

Update by Shawn Pearce <sop@google.com> on Wed Apr 01 07:27:48 PDT 2009

Fixed in version 1.6.4.

Original comment by code-rev...@gtempaccount.com on 24 Sep 2009 at 9:10

  • Changed state: Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant