Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JS Style Guide: Fix full file closures #106

Closed
wants to merge 4 commits into from

Conversation

scottgonzalez
Copy link
Member

No description provided.

@jzaefferer
Copy link
Member

👍

Could use the opportunity to add an example for node, e.g. a Gruntfile.js, something like this:

var path = require( "path" );

module.exports = function( grunt ) {

grunt.registerTask( "custom task", function() {
    // task impl
} );

};

@scottgonzalez
Copy link
Member Author

Added.

```

```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing js language instruction

@arthurvr
Copy link
Member

Looking good 👍

// This doesn't get indented

};

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also missing closing backticks, messing up the highlighting of the remaining file...

@jzaefferer
Copy link
Member

Good to land.

@scottgonzalez scottgonzalez deleted the closure-spacing branch March 23, 2015 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants