Release 1.2.5 #1085
Closed
Release 1.2.5 #1085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With Node.js >= 0.11, the outdated JSLint package does not work anymore. Refs jquery#1083
|
@scottgonzalez The CLA checker did flag this again. |
|
I'm guessing the part of the script that fetches updated signatures isn't working. I've filed jquery/jquery-license#22 and I'll dig in to this on Monday. |
|
Just curious... Why the JSLint skip? |
|
👍 |
For some unknown reason, Node.js >= 0.11 fails to run it properly. |
|
Landed in 1.2 branch! |
|
@ariya There was in fact a problem with the signatures not getting updated while the server was running. I've just pushed an update that fixes that problem so future PRs shouldn't have that issue. |
|
@scottgonzalez Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport implicit octal scanning, release housekeeping.