Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow let as a bound identifier in a for-in statement. #1337

Closed
wants to merge 1 commit into from
Closed

Allow let as a bound identifier in a for-in statement. #1337

wants to merge 1 commit into from

Conversation

ariya
Copy link
Contributor

@ariya ariya commented Oct 6, 2015

Fixes #1334

@codecov-io
Copy link

Current coverage is 100.00%

Merging #1337 into master will not affect coverage as of c655012

@@            master   #1337   diff @@
======================================
  Files            1       1       
  Stmts         3034    3040     +6
  Branches       598     599     +1
  Methods          0       0       
======================================
+ Hit           3034    3040     +6
  Partial          0       0       
  Missed           0       0

Review entire Coverage Diff as of c655012

Powered by Codecov. Updated on successful CI builds.

@mikesherov
Copy link
Member

👍

@michaelficarra
Copy link
Contributor

This diff is considerably simpler: https://github.com/jquery/esprima/pull/1337/files?w=1

👍

@ariya ariya closed this in 9e2874d Oct 6, 2015
@ariya ariya deleted the let-id branch October 6, 2015 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ariya @codecov-io @mikesherov @michaelficarra @jquerybot